Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Changeable cutoff for number of genes found in DB for module2df #387

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

klprint
Copy link

@klprint klprint commented Apr 12, 2022

Hi!

I added the possibility that users can freely choose the cutoff for module2df in the ctx step of pySCENIC.
I had the issue that this error was triggered for a majority of the identified modules (as others also reported).

All I did was adding a CLI argument and implemented the manual cutoff in the module2df function, as well as all other functions that rely on module2df. I hope I found all of them.

According to my testing, the default settings work as previously, but now the user is able to lower the cutoff to whatever percentage he/she wants. I think this makes pySCENIC more flexible. If you think there should be a minimum cutoff, let me know. I think you had a good reason to set it to 80%.

I'd also want to add: Thank you for this great tool and the nice python implementation of it 😄

All the best,
Kevin

pytest output:

pySCENIC on  relax_module2df via 🐍 v3.7.13 via 🅒 pstest took 4s
❯ pytest -v
=================================================== test session starts ====================================================
platform linux -- Python 3.7.13, pytest-7.1.1, pluggy-1.0.0 -- /home/kevin/miniconda3/envs/pstest/bin/python
cachedir: .pytest_cache
rootdir: /home/kevin/git/pySCENIC
collected 8 items

tests/test_aucell.py::test_create_rankings PASSED                                                                    [ 12%]
tests/test_aucell.py::test_aucell_w1 PASSED                                                                          [ 25%]
tests/test_aucell.py::test_aucell_w2 PASSED                                                                          [ 37%]
tests/test_aucell.py::test_aucell_mismatch PASSED                                                                    [ 50%]
tests/test_featureseq.py::test_feature_overlap PASSED                                                                [ 62%]
tests/test_featureseq.py::test_feature_contains PASSED                                                               [ 75%]
tests/test_featureseq.py::test_feature_bp_overlap PASSED                                                             [ 87%]
tests/test_math.py::test_masked_rho PASSED                                                                           [100%]

==================================================== 8 passed in 15.96s ====================================================

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants