Remove the intercept assumption in Gibbs samplers #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The samplers currently assume that there is an intercept term in the
regressions, and this term is treated separately from the other
regression parameters (Makalic & Schmidt 2016). This is limiting for two
reasons:
at the very least we'd like to control its prior value.
In this commit we generalize the Gibbs samplers by removing
the separation between the intercept beta0 and the other regression parameters.
Closes #17
@brandonwillard Many references mention having a separate prior for the intercept parameter, which does make sense. Are there cases that you know of where adding a shrinkage prior to the intercept changes the results?
Also I've noticed we don't have any tests to check that the samplers sample from the correct posterior distribution. We may want to add this in the near future.