feat: Strip/ignore whitespace in nodes #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afnanenayet
force-pushed
the
afnan/strip-whitespace
branch
from
7d87cdc to
c733618
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
==========================================
- Coverage 59.47% 59.00% -0.48%
==========================================
Files 13 13
Lines 1451 1488 +37
==========================================
+ Hits 863 878 +15
- Misses 588 610 +22 ☔ View full report in Codecov by Sentry. |
Add an option to ignore whitespace within nodes. This also adds some performance improvements by reducing copies. We uncovered extra copies when refactoring the code and removed them. This also refactors some code to be simpler and cleans up the APIs around constructing tree sitter parsers for specific languages, which also makes testing easier.
afnanenayet
force-pushed
the
afnan/strip-whitespace
branch
from
9e0b1d8 to
20a769e
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some code and allows for stripping whitespace/newlines from the diffs when processing the tree-sitter AST. This yields more granular diffs that don't break on whitespace differences and newlines, which seems to be desirable.
This also updates some APIs for constructing tree-sitter grammars which makes it easier to make unit tests.