AG-13024 Add context object to API
#3679
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegat
changed the title
context object to APOcontext object to API
olegat
force-pushed
the
AG-13024/add_context_object_to_api
branch
2 times, most recently
from
6fc5031 to
ac046ae
Compare
Jest fails with this message:
expect(received).toBe(expected) // Object.is equality
If it should pass with deep equality, replace "toBe" with "toStrictEqual"
Expected: {}
Received: serializes to the same string
This could persuade a developer to switch this to `toStrictEqual`, which would
be incorrect.
olegat
force-pushed
the
AG-13024/add_context_object_to_api
branch
from
ac046ae to
7fe67a2
Compare
alantreadway
requested changes
Feb 28, 2025
| @@ -3,6 +3,9 @@ import { Logger, isArray } from 'ag-charts-core'; | |||
| import { extractDecoratedPropertyMetadata, listDecoratedProperties } from './decorator'; | |||
|
|
|||
| export class BaseProperties<T extends object = object> { | |||
| // user pass-through option: no validation-decorator required. | |||
| context?: unknown; | |||
There was a problem hiding this comment.
I don't think this is the right class for this, as it's used as the base class for a lot of use-cases where this isn't relevant - perhaps we could have a ContextProperties extends BaseProperties base class with the context-related behaviours, which is extended in the specific cases where this behaviour is needed?
There was a problem hiding this comment.
it's used as the base class for a lot of use-cases where this isn't relevant
Why does this matter?
Removing this property will raise this compiler error:
packages/ag-charts-community/src/util/properties.ts:41:18 - error TS2339: Property 'context' does not exist on type 'BaseProperties<T>'.
39 | }
40 | if ('context' in properties) {
> 41 | this.context = properties.context;
| ^
42 | keys.delete('context');
43 | }
44 | for (const unknownKey of keys) {
This if is necessary to avoid warnings
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-13024