ci: migrate to GH actions #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mostly duplicate what I have in [react-signature-canvas](https://github.com/agilgur5/react-signature-canvas/blob/main/.github/workflows/ci.yml) - update LTS Node versions to 18.x and 20.x - comment out linting step for now as `ts-standard` hasn't been configured in this repo - add `tsc` and `test:coverage` scripts for CI - had to specify `--noEmit` for now, the whole build system will need to be revamped later - replace Travis badge with GH Actions badge
agilgur5
commented
Jul 13, 2023
There was a problem hiding this comment.
awesome, tests pass on the new GH Actions CI!
had to modify branch protection for the new checks and had to reactivate Codecov (which is glitching on the master -> main branch rename), but otherwise seems to be working 🙂
thankfully was pretty straightforward when copying existing code!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate over to GH Actions from Travis
Details
mostly duplicate what I have in react-signature-canvas
ts-standardhasn't been configured in this repoadd
tscandtest:coveragescripts for CI--noEmitfor now, the whole build system will need to be revamped laterreplace Travis badge with GH Actions badge