Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add JSON file support for file input #2009

Merged
merged 10 commits into from
Feb 6, 2025

Conversation

pritipsingh
Copy link
Contributor

Description

  • Summary of changes: Describe the key changes in this PR and their purpose.
  • Related issues: Mention if this PR fixes or is connected to any issues.
  • Motivation and context: Explain the reason for the changes and the problem they solve.
  • Environment or dependencies: Specify any changes in dependencies or environment configurations required for this update.
  • Impact on metrics: (If applicable) Describe changes in any metrics or performance benchmarks.

Fixes # (issue)


Type of change

Please check the options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Model update (Addition or modification of models)
  • Other (please describe):

Checklist

  • Adherence to standards: Code complies with Agno’s style guidelines and best practices.
  • Formatting and validation: You have run ./scripts/format.sh and ./scripts/validate.sh to ensure code is formatted and linted.
  • Self-review completed: A thorough review has been performed by the contributor(s).
  • Documentation: Docstrings and comments have been added or updated for any complex logic.
  • Examples and guides: Relevant cookbook examples have been included or updated (if applicable).
  • Tested in a clean environment: Changes have been tested in a clean environment to confirm expected behavior.
  • Tests (optional): Tests have been added or updated to cover any new or changed functionality.

Additional Notes

Include any deployment notes, performance implications, security considerations, or other relevant information (e.g., screenshots or logs if applicable).

@pritipsingh pritipsingh requested a review from a team as a code owner February 4, 2025 16:31
@dirkbrnd dirkbrnd merged commit d9dbcbd into main Feb 6, 2025
1 check passed
@dirkbrnd dirkbrnd deleted the add-json-file-support-for-file-input-ag-2494 branch February 6, 2025 14:04
@AyushUnleashed
Copy link

I was curious, Why the codebase of agno uses print statements instead of a logging library? @pritipsingh

@manthanguptaa
Copy link
Contributor

@AyushUnleashed we use logging library for internal SDK code. You will find print statements in the cookbooks only where we showcase the examples

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants