configstore: fix deleteUser query

agola-io · Sep 14, 2022 · a5bbfe3 · a5bbfe3
1 parent 2aafb20
commit a5bbfe3
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/internal/services/configstore/configstore_test.go b/internal/services/configstore/configstore_test.go
@@ -433,6 +433,31 @@ func TestUser(t *testing.T) {
 			t.Fatalf("expected %d users, got %d", len(prevUsers)+1, len(users))
 		}
 	})
+
+	t.Run("delete user", func(t *testing.T) {
+		_, err := cs.ah.CreateUser(ctx, &action.CreateUserRequest{UserName: "user03"})
+		if err != nil {
+			t.Fatalf("unexpected err: %v", err)
+		}
+
+		err = cs.ah.DeleteUser(ctx, "user03")
+		if err != nil {
+			t.Fatalf("unexpected err: %v", err)
+		}
+
+		var user *types.User
+		err = cs.d.Do(ctx, func(tx *sql.Tx) error {
+			var err error
+			user, err = cs.d.GetUser(tx, "user03")
+			return errors.WithStack(err)
+		})
+		if err != nil {
+			t.Fatalf("unexpected err: %v", err)
+		}
+		if user != nil {
+			t.Fatalf("expected user nil, got: %v", user)
+		}
+	})
 }
 
 func TestProjectGroupsAndProjectsCreate(t *testing.T) {

diff --git a/internal/services/configstore/db/qtables.go b/internal/services/configstore/db/qtables.go
@@ -166,8 +166,8 @@ func (d *DB) updateUserQ(tx *sql.Tx, user *types.User, data []byte) error {
 }
 
 func (d *DB) deleteUserQ(tx *sql.Tx, id string) error {
-	if _, err := tx.Exec("delete from user_q where id = $1", id); err != nil {
-		return errors.Wrapf(err, "failed to delete user_q")
+	if _, err := tx.Exec("delete from user_t_q where id = $1", id); err != nil {
+		return errors.Wrapf(err, "failed to delete user_t_q")
 	}
 
 	return nil