Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

runconfig: test task generation with on_skipped dependencies #302

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

alessandro-sorint
Copy link
Contributor

add test for PR #290

Copy link
Member

@sgotti sgotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alessandro-sorint Thanks for the PR. Can you please reduce the in/out data to reduce their size since they contains many stuff not needed to just test the on_skipped condition generation?

@alessandro-sorint
Copy link
Contributor Author

@sgotti i I reduced some datas in/out it's ok?

@alessandro-sorint alessandro-sorint changed the title added test runconfig with task depends on_skipped runconfig: test task generation with on_skipped dependencies Feb 1, 2022
@sgotti
Copy link
Member

sgotti commented Feb 1, 2022

@alessandro-sorint Thanks! LGTM. Merging.

@sgotti sgotti merged commit 40bc118 into agola-io:master Feb 1, 2022
@alessandro-sorint alessandro-sorint deleted the test_on_skipped branch February 14, 2022 14:52
tulliobotti64 pushed a commit to tulliobotti64/agola that referenced this pull request Oct 19, 2022
runconfig: test task generation with on_skipped dependencies
tulliobotti64 pushed a commit to tulliobotti64/agola that referenced this pull request Oct 19, 2022
runconfig: test task generation with on_skipped dependencies
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants