-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
runservice: add tasks timeout #331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c0d893
to
a6a8d61
Compare
a6a8d61
to
13048c1
Compare
sgotti
requested changes
May 26, 2022
6558982
to
4545f35
Compare
e9d84ca
to
5b62de2
Compare
@sgotti can you do the review please? |
be27700
to
4272219
Compare
@sgotti can you do the review please? |
sgotti
requested changes
Jun 3, 2022
4272219
to
e95625e
Compare
e95625e
to
0810247
Compare
sgotti
requested changes
Jun 6, 2022
0810247
to
e33b7c7
Compare
sgotti
reviewed
Jun 7, 2022
sgotti
requested changes
Jun 7, 2022
e33b7c7
to
dd54ee2
Compare
63f81f4
to
32fb5c9
Compare
32fb5c9
to
b1c400d
Compare
sgotti
requested changes
Jun 10, 2022
eadf85f
to
b8dca5f
Compare
sgotti
requested changes
Jul 13, 2022
b8dca5f
to
97f5913
Compare
@sgotti can you do the review please? |
sgotti
requested changes
Jul 15, 2022
97f5913
to
744ea72
Compare
744ea72
to
3e4d935
Compare
config/runconfig: add fields to set task timeout at the global, run and task level runservice/executor: handle tasks timeout
3e4d935
to
04b426b
Compare
sgotti
approved these changes
Aug 1, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6
runConfig: added TaskTimeout in global, run and task configuration
executor: added tasksTimeoutCleaner for managing task timeout
scheduler: updated executorTaskCleaner for managing task timeout and report it to the executor with a timeout signal in ExecutorTaskSpec