testutils/db: use schema provided by migrate data during export #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgotti
requested changes
Oct 10, 2023
internal/testutil/db.go
Outdated
| @@ -672,6 +672,8 @@ func TestMigrate(t *testing.T, lastVersion uint, dataFixtures DataFixtures, setu | |||
|
|
|||
| assert.Assert(t, len(diff) == 0, "schema of db created at version %d and db migrated from version %d to version %d is different:\n %s", migrateVersion, createVersion, migrateVersion, diff) | |||
|
|
|||
| dc.Schema = createDC.Schema | |||
There was a problem hiding this comment.
please add a comment explaining the reason of this change.
internal/testutil/db.go
Outdated
| @@ -672,6 +672,8 @@ func TestMigrate(t *testing.T, lastVersion uint, dataFixtures DataFixtures, setu | |||
|
|
|||
| assert.Assert(t, len(diff) == 0, "schema of db created at version %d and db migrated from version %d to version %d is different:\n %s", migrateVersion, createVersion, migrateVersion, diff) | |||
|
|
|||
| dc.Schema = createDC.Schema | |||
There was a problem hiding this comment.
I'll prefer to use the source variable:
dc.Schema = createDataCreate.Tables
alessandro-sorint
force-pushed
the
fix-testutil
branch
from
63b42b6 to
1456af2
Compare
sgotti
reviewed
Oct 10, 2023
internal/testutil/db.go
Outdated
| @@ -672,6 +672,9 @@ func TestMigrate(t *testing.T, lastVersion uint, dataFixtures DataFixtures, setu | |||
|
|
|||
| assert.Assert(t, len(diff) == 0, "schema of db created at version %d and db migrated from version %d to version %d is different:\n %s", migrateVersion, createVersion, migrateVersion, diff) | |||
|
|
|||
| // MigrateToVersion update the db schema but not change the DBContext | |||
There was a problem hiding this comment.
// set the db schema at the migrated version.
alessandro-sorint
force-pushed
the
fix-testutil
branch
from
1456af2 to
fd0e079
Compare
When exporting, use schema provided by migrate data and not the create data since the migration change the db shema to the migrate version.
alessandro-sorint
force-pushed
the
fix-testutil
branch
from
fd0e079 to
1b4e220
Compare
sgotti
approved these changes
Oct 10, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporting, use schema provided by migrate data and not the create data since the migration change the db shema to the migrate version.