-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
skip run with special commit #90
Conversation
@camandel Thanks for your PR! The idea in #51 wasn't clear but I'd not put a skip message option in the run config. P.S. Don't close this PR but just update it |
@camandel I saw you updated the PR. The implementation looks good to me but we need some tests to check that everything works. Before merging it can you add some integration tests under |
ea6fc54
to
a505c4e
Compare
I added the integration tests. I'm not sure because the run failed on TestCreateProject, the same function is used in other tests that passed. |
@camandel Please rebase into current master your commit and force push instead of merging master inside your branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camandel LGTM. Thanks!
skip run with special commit
skip run with special commit
I've tried to fix issue #51 adding a new option (skip_message) at "run" level:
if the commit message contains the string specified in skip_message, for instance "[ci skip] Update README", run01 will be skipped and only run02 will be processed.