runservice: fix get tasks to run #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `advanceRunTasks` isn't deterministic and doesn't calculate the final state in one call. So could happen that `getTasksToRun` will select a task to be executed since its parent are finished (marked as skipped in advanceRunTasks) but the task isn't marked to be skipped (because advanceRunTasks has calculated this task before its parents). Currently fix this doing the same task selection logic done in `advanceRunTasks` and add a TODO to make `advanceRunTasks` be deterministic by processing tasks by their level (from level 0).
sgotti
force-pushed
the
runservice_fix_gettaskstorun
branch
from
e414b58 to
bfc42ef
Compare
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
runservice: fix get tasks to run
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
runservice: fix get tasks to run
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
advanceRunTasksisn't deterministic and doesn't calculate the finalstate in one call. So could happen that
getTasksToRunwill select a task to beexecuted since its parent are finished (marked as skipped in advanceRunTasks)
but the task isn't marked to be skipped (because advanceRunTasks has calculated
this task before its parents).
Currently fix this doing the same task selection logic done in
advanceRunTasksand add a TODO to make
advanceRunTasksbe deterministic by processing tasks bytheir level (from level 0).