Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update logfile_viewer.html for Django 3.0 #5

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

squio
Copy link
Contributor

@squio squio commented Jan 7, 2020

load admin_static was deprecated in favor of load static and completely removed in Django 3.0

`load admin_static` was deprecated in favor of `load static` and completely removed in Django 3.0
@agusmakmun
Copy link
Owner

@squio unfortunately in the django template it doesn't have a try except. so we can't handle multiple versions.

@squio
Copy link
Contributor Author

squio commented Jan 8, 2020

@squio unfortunately in the django template it doesn't have a try except. so we can't handle multiple versions.

Would this be a backward compatibility problem for Django 2.2? Or for 1.x?
This issue is the only one left for our app before migrating to Django 3.0 so it would be great if this can be merged in the next release

@agusmakmun
Copy link
Owner

agusmakmun commented Jan 9, 2020

@squio I checked at the doc says, this feature has deprecated since django 2.1.
I think it not a big problem for django >= 2.1. I'll merge your great P.R 👍

https://docs.djangoproject.com/en/2.2/releases/2.1/#features-deprecated-in-2-1

{% load staticfiles %} and {% load admin_static %} are deprecated in favor of {% load static %}, which works the same.

@agusmakmun agusmakmun merged commit bef46a3 into agusmakmun:master Jan 9, 2020
@squio squio deleted the patch-1 branch January 10, 2020 10:19
@squio
Copy link
Contributor Author

squio commented Jan 10, 2020

Thanks! Could you please create a new release so we can upgrade directly from PyPi?

@agusmakmun
Copy link
Owner

@squio well done.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants