Make from_path attribute private

aidewoode · Aug 6, 2024 · 0dc8bd0 · 0dc8bd0
1 parent 935906e
commit 0dc8bd0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/lib/wahwah/tag.rb b/lib/wahwah/tag.rb
@@ -22,7 +22,6 @@ class Tag
       sample_rate
       bit_depth
       file_size
-      from_path
     ]
 
     attr_reader(*INSPECT_ATTRIBUTES)
@@ -60,6 +59,8 @@ def images
 
     private
 
+    attr_accessor :from_path
+
     def parse
       raise WahWahNotImplementedError, "The parse method is not implemented"
     end

diff --git a/test/files/test-recording-123.m4a → test/files/extended_header_atom.m4a b/test/files/test-recording-123.m4a → test/files/extended_header_atom.m4a
diff --git a/test/wahwah/mp4_tag_test.rb b/test/wahwah/mp4_tag_test.rb
@@ -90,8 +90,8 @@ def test_parse_alac_encoded
     end
   end
 
-  def test_parse_on_other_m4a
-    File.open "test/files/test-recording-123.m4a" do |file|
+  def test_parse_extended_header_atom
+    File.open "test/files/extended_header_atom.m4a" do |file|
       tag = WahWah::Mp4Tag.new(file)
       meta_atom = WahWah::Mp4::Atom.find(File.open(file.path), "moov", "udta", "meta")
       image = tag.images.first