Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Apply mypy for checking #594

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Jan 17, 2024

No description provided.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (622a922) 80.86% compared to head (ab59ae8) 80.92%.

Files Patch % Lines
src/aiidalab_qe/app/configuration/pseudos.py 88.88% 1 Missing ⚠️
src/aiidalab_qe/app/result/__init__.py 0.00% 1 Missing ⚠️
src/aiidalab_qe/app/result/workchain_viewer.py 50.00% 1 Missing ⚠️
src/aiidalab_qe/app/submission/__init__.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   80.86%   80.92%   +0.05%     
==========================================
  Files          49       49              
  Lines        3429     3433       +4     
==========================================
+ Hits         2773     2778       +5     
+ Misses        656      655       -1     
Flag Coverage Δ
python-3.10 80.92% <80.00%> (+0.05%) ⬆️
python-3.8 80.96% <80.00%> (+0.05%) ⬆️
python-3.9 80.96% <80.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz unkcpz marked this pull request as draft January 17, 2024 15:59
@unkcpz unkcpz force-pushed the refac/xx/to-mypy branch 3 times, most recently from d4f1a77 to 1aef5fe Compare January 19, 2024 11:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant