Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Blog post: Debug async in AiiDA #86

Merged
merged 7 commits into from
Jan 31, 2025
Merged

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Jan 28, 2025

No description provided.

@unkcpz
Copy link
Member Author

unkcpz commented Jan 28, 2025

The linkcheck is fail but it actually work, is that possible to just ignore the check for certain links?

@GeigerJ2
Copy link
Contributor

The linkcheck is fail but it actually work, is that possible to just ignore the check for certain links?

Yeah, this has been happening for basically every PR here... I'll have a look, maybe we can ignore the offending links. Sometimes, one can access them normally from the browser, but it fails for the GHA runners.

@unkcpz
Copy link
Member Author

unkcpz commented Jan 28, 2025

I think it can be added

linkcheck_ignore = [
to ignore.

Copy link
Member Author

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking text @GeigerJ2 looks much better. I further push some tiny changes.

Copy link
Contributor

@GeigerJ2 GeigerJ2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unkcpz just added one more commit with some minor text corrections. Thank you, nice work!

@unkcpz
Copy link
Member Author

unkcpz commented Jan 30, 2025

thank you for the review and correct my grammar. I'll let you press the the merge button. I'll all good with the content.

@GeigerJ2 GeigerJ2 merged commit 82fcae0 into aiidateam:main Jan 31, 2025
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants