Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

use get_processes_latest for workgraph.update #174

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Jul 17, 2024

  • use get_processes_latest for workgraph.update
  • serialize task.process in to_dict
  • handle data node and process ndoe differently
    • when loading the WorkGraph and reading outputs of the tasks
    • When setting the results of the task in the context of the Engine

- when load the WorkGraph and read outputs of the tasks
- When set the results of the task in context of the Engine
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.80%. Comparing base (01007f4) to head (5c74088).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   75.28%   75.80%   +0.52%     
==========================================
  Files          69       69              
  Lines        4616     4608       -8     
==========================================
+ Hits         3475     3493      +18     
+ Misses       1141     1115      -26     
Flag Coverage Δ
python-3.11 75.71% <100.00%> (+0.52%) ⬆️
python-3.9 75.78% <100.00%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 linked an issue Jul 17, 2024 that may be closed by this pull request
@superstar54 superstar54 merged commit 24c9239 into main Jul 17, 2024
11 checks passed
@superstar54 superstar54 deleted the fix/151/update_task_state_for_widget branch July 17, 2024 07:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update task state is not correct in widget
2 participants