Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: avoid empty module set when inspecting the type annotations #220

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Aug 13, 2024

This PR makes sure all the modules set to be imported are not empty.

@superstar54 superstar54 changed the title avoid empty module set Fix: avoid empty module set when inspecting the type annotations Aug 13, 2024
@superstar54 superstar54 added the bug Something isn't working label Aug 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.01%. Comparing base (5937b88) to head (da6519d).
Report is 20 commits behind head on main.

Files Patch % Lines
tests/test_python.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   75.75%   76.01%   +0.26%     
==========================================
  Files          70       70              
  Lines        4615     4904     +289     
==========================================
+ Hits         3496     3728     +232     
- Misses       1119     1176      +57     
Flag Coverage Δ
python-3.11 75.89% <83.33%> (+0.23%) ⬆️
python-3.12 75.91% <83.33%> (?)
python-3.9 75.96% <83.33%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit b4d4641 into main Aug 13, 2024
8 checks passed
@superstar54 superstar54 deleted the fix/python_job_typing branch August 13, 2024 13:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants