Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update parent task's state even if the task fails #311

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Sep 13, 2024

The problem is that when certain tasks (calcfunction, normal) fail, it does not update their parent state thus the workgraph engine goes into an infinite loop.

In case a task fails, we also need to update the state of its parent task.

@superstar54 superstar54 changed the title update normal task state Update parent task's state even if the task fails Sep 13, 2024
@superstar54 superstar54 merged commit ab44e1f into main Sep 13, 2024
7 of 8 checks passed
@superstar54 superstar54 deleted the fix/310/while_failed_task branch September 13, 2024 18:57
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 83.67347% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.74%. Comparing base (5937b88) to head (f19ae0f).
Report is 73 commits behind head on main.

Files with missing lines Patch % Lines
aiida_workgraph/engine/workgraph.py 83.67% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   75.75%   80.74%   +4.99%     
==========================================
  Files          70       66       -4     
  Lines        4615     5084     +469     
==========================================
+ Hits         3496     4105     +609     
+ Misses       1119      979     -140     
Flag Coverage Δ
python-3.11 80.66% <83.67%> (+4.99%) ⬆️
python-3.12 80.66% <83.67%> (?)
python-3.9 80.70% <83.67%> (+4.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants