Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move PythonJob out #364

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Move PythonJob out #364

merged 4 commits into from
Nov 28, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Nov 28, 2024

This PR moves the PythonJob out aiida-workgraph. And add the aiida-pythonjob package as a dependency.

The PythonJob related data and the serializer have been moved out too.

@superstar54 superstar54 changed the title Remove PythonJob Move PythonJob out Nov 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 97.95918% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.96%. Comparing base (5937b88) to head (a39787f).
Report is 100 commits behind head on main.

Files with missing lines Patch % Lines
aiida_workgraph/engine/utils.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
+ Coverage   75.75%   79.96%   +4.20%     
==========================================
  Files          70       61       -9     
  Lines        4615     4846     +231     
==========================================
+ Hits         3496     3875     +379     
+ Misses       1119      971     -148     
Flag Coverage Δ
python-3.11 79.90% <97.95%> (+4.23%) ⬆️
python-3.12 79.90% <97.95%> (?)
python-3.9 79.95% <97.95%> (+4.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit 0d6141f into main Nov 28, 2024
8 checks passed
@superstar54 superstar54 deleted the remove_pythonjob branch November 28, 2024 19:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants