Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

create input sockets and links for items inside a dynamic socket #381

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Dec 5, 2024

For the AiiDA dynamic port in the CalcJob or WorkChain, create an input socket for each item. If the value of the item is a Socket, create a link in the WorkGraph and pop out the value.

@superstar54 superstar54 linked an issue Dec 5, 2024 that may be closed by this pull request
@superstar54 superstar54 force-pushed the fix/362/check_link_in_dynamic_socket branch from f4a631a to ab64c3e Compare December 5, 2024 10:27
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.84%. Comparing base (02e1c48) to head (eaa52a6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   90.79%   90.84%   +0.05%     
==========================================
  Files          64       64              
  Lines        4583     4601      +18     
==========================================
+ Hits         4161     4180      +19     
+ Misses        422      421       -1     
Flag Coverage Δ
python-3.11 90.80% <100.00%> (+0.05%) ⬆️
python-3.12 90.78% <100.00%> (+0.03%) ⬆️
python-3.9 90.82% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit c08af7a into main Dec 5, 2024
15 checks passed
@superstar54 superstar54 deleted the fix/362/check_link_in_dynamic_socket branch December 5, 2024 12:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass Socket in to a dynamic namespace raise an error
2 participants