Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Devops: adopt PEP 621 and move build spec to pyproject.toml #230

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

sphuber
Copy link
Collaborator

@sphuber sphuber commented Apr 8, 2022

Following PEP 621 it is now possible to fully define the build procedure
of your package in pyproject.toml. Since this PEP is now well
supported, and for example pip can use it, we migrate to it since it
provides a bunch of benefits:

  • No longer need the deprecated setup.py to install the package.
  • Version number is now dynamically fetched from the package.
  • The MANIFEST.in is no longer necessary. The flit build tool will
    automatically include anything. The pyproject.toml has a tool
    section for flit that excludes the tests and docs folders.
  • Move configuration of pre-commit tools to pyproject.toml.

Following PEP 621 it is now possible to fully define the build procedure
of your package in `pyproject.toml`. Since this PEP is now well
supported, and for example `pip` can use it, we migrate to it since it
provides a bunch of benefits:

 * No longer need the deprecated `setup.py` to install the package.
 * Version number is now dynamically fetched from the package.
 * The `MANIFEST.in` is no longer necessary. The `flit` build tool will
   automatically include anything. The `pyproject.toml` has a tool
   section for `flit` that excludes the `tests` and `docs` folders.
 * Move configuration of pre-commit tools to `pyproject.toml`.
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #230 (d293943) into develop (c500b99) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #230      +/-   ##
===========================================
- Coverage    90.56%   90.55%   -0.00%     
===========================================
  Files           22       21       -1     
  Lines         2974     2972       -2     
===========================================
- Hits          2693     2691       -2     
  Misses         281      281              
Impacted Files Coverage Δ
plumpy/__init__.py 100.00% <100.00%> (ø)
plumpy/ports.py 93.01% <100.00%> (ø)
plumpy/utils.py 81.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c500b99...d293943. Read the comment docs.

@sphuber sphuber merged commit d293943 into develop Apr 8, 2022
sphuber added a commit that referenced this pull request Apr 8, 2022
Following PEP 621 it is now possible to fully define the build procedure
of your package in `pyproject.toml`. Since this PEP is now well
supported, and for example `pip` can use it, we migrate to it since it
provides a bunch of benefits:

 * No longer need the deprecated `setup.py` to install the package.
 * Version number is now dynamically fetched from the package.
 * The `MANIFEST.in` is no longer necessary. The `flit` build tool will
   automatically include anything. The `pyproject.toml` has a tool
   section for `flit` that excludes the `tests` and `docs` folders.
 * Move configuration of pre-commit tools to `pyproject.toml`.
@sphuber sphuber deleted the fix/adopt-pep-621 branch April 8, 2022 14:57
unkcpz pushed a commit to unkcpz/plumpy that referenced this pull request Dec 14, 2024
…eam#230)

Following PEP 621 it is now possible to fully define the build procedure
of your package in `pyproject.toml`. Since this PEP is now well
supported, and for example `pip` can use it, we migrate to it since it
provides a bunch of benefits:

 * No longer need the deprecated `setup.py` to install the package.
 * Version number is now dynamically fetched from the package.
 * The `MANIFEST.in` is no longer necessary. The `flit` build tool will
   automatically include anything. The `pyproject.toml` has a tool
   section for `flit` that excludes the `tests` and `docs` folders.
 * Move configuration of pre-commit tools to `pyproject.toml`.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant