changed return type of simulated annealing #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks to be correct. However, the issue is in the not to be changed AIMA3e version of the pseudocode. I would recommend submitting an issue indicating it should be addressed in the aima4e version of the pseudocode. Thanks Ciaran |
|
@ctjoreilly I am sorry I was unfamiliar with the workflow. I got confused because of the README stating that the 4th edition algorithms would be updated here. Is there a separate branch I should contribute to, yet, or should I just open an issue for now? Thanks. |
|
Hi,
For now I would submit as an issue. I've pinged Peter Norvig in order to
help clarify the workflow. For pseudocode that will be present in AIMA4e as
well as AIMA3e and there are changes planned, a version of the psuedocode
with the changes will be written in the same .md file under an AIMA4e
header so the two versions can be compared.
Best
Ciaran
…On Sun, Mar 19, 2017 at 2:45 AM, Kaivalya Rawal ***@***.***> wrote:
@ctjoreilly <https://github.com/ctjoreilly> I am sorry I was unfamiliar
with the workflow. I got confused because of the README stating that the
4th edition algorithms would be updated here. Is there a separate branch I
should contribute to, yet, or should I just open an issue for now?
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA0Du1QEaE1zIfqI8lpR1kbJNsiE4qWAks5rnPkdgaJpZM4MhCGk>
.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function header declares a return type of
state, however anodewas being returned. This fixes the return type tostate.