Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Leverage CodeQL default setup for code scanning #1143

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

CodeQL recommends default setup for code scanning. Default setup does not require any configuration in .github/workflows.

Assumptions

CodeQL advanced setup is not required for this project.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the github_actions Pull requests that update GitHub Actions code label Aug 18, 2024
@jakob-keller jakob-keller self-assigned this Aug 18, 2024
@jakob-keller jakob-keller marked this pull request as ready for review August 18, 2024 00:03
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.98%. Comparing base (90cc4f9) to head (3f9021a).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1143      +/-   ##
==========================================
- Coverage   87.03%   86.98%   -0.06%     
==========================================
  Files          64       64              
  Lines        5970     5970              
==========================================
- Hits         5196     5193       -3     
- Misses        774      777       +3     
Flag Coverage Δ
unittests 86.98% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller merged commit 42c8caa into aio-libs:master Aug 19, 2024
11 checks passed
@jakob-keller jakob-keller deleted the codeql branch August 19, 2024 18:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants