Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

check that git tag matches version in CI/CD #1245

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Check that git tag matches version in CI/CD.

Assumptions

Replace this text with any assumptions made (if any)

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): closes Check that git tag matches version in CI/CD #1182
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller added the github_actions Pull requests that update GitHub Actions code label Dec 29, 2024
@jakob-keller jakob-keller self-assigned this Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base (f9975dd) to head (ef15f97).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
+ Coverage   88.00%   88.02%   +0.01%     
==========================================
  Files          67       67              
  Lines        5904     5904              
==========================================
+ Hits         5196     5197       +1     
+ Misses        708      707       -1     
Flag Coverage Δ
unittests 88.02% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller added this pull request to the merge queue Dec 29, 2024
Merged via the queue into aio-libs:master with commit 24108bf Dec 29, 2024
11 checks passed
@jakob-keller jakob-keller deleted the validate-version-in-ci branch December 29, 2024 15:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that git tag matches version in CI/CD
2 participants