Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

HttpMessage._add_default_headers should not overwrite existing headers #216

Closed
wolfhechel opened this issue Dec 30, 2014 · 2 comments
Closed

HttpMessage._add_default_headers should not overwrite existing headers #216

wolfhechel opened this issue Dec 30, 2014 · 2 comments
Labels
outdated

Comments

@wolfhechel
Copy link
Contributor

Simply using setdefault should suffice rather than extend.

This is crucial for custom protocol extensions where the Server / User-Agent headers is used to
notify clients/servers about capabilities.
asvetlov added a commit that referenced this issue Jan 2, 2015
@asvetlov
Merge pull request #219 from KeepSafe/issue_216_dont_override_headers
26f380b 
Fix #216: HttpMessage._add_default_headers does not overwrite existing headers
@asvetlov
Copy link
Member

asvetlov commented Jan 2, 2015

Fixed

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asvetlov @wolfhechel