-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Avoid constructing headers mulitidict twice for web.Response
#10043
Conversation
CodSpeed Performance ReportMerging #10043 will improve performances by 14.7%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10043 +/- ##
==========================================
+ Coverage 98.03% 98.73% +0.69%
==========================================
Files 122 121 -1
Lines 36930 36768 -162
Branches 4449 4393 -56
==========================================
+ Hits 36205 36303 +98
+ Misses 543 314 -229
+ Partials 182 151 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
web.Response
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 5255cec on top of patchback/backports/3.11/5255cecfe73c2be59e7e207449783635f4b978a2/pr-10043 Backporting merged PR #10043 into master
🤖 @patchback |
Backport to 3.12: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 5255cec on top of patchback/backports/3.12/5255cecfe73c2be59e7e207449783635f4b978a2/pr-10043 Backporting merged PR #10043 into master
🤖 @patchback |
) (cherry picked from commit 5255cec)
) (cherry picked from commit 5255cec)
…ict twice for ``web.Response`` (#10045)
…ict twice for ``web.Response`` (#10046)
web.Response
constructed the headersCIMultiDict
, and than passed it toweb.StreamResponse
which would construct a newCIMultiDict
from the one that was just built inweb.Response
and than throw away the first constructed one.