Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Restore total_bytes to EmptyStreamReader #10387

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 5, 2025

What do these changes do?

fixes #10386

Are there changes in behavior for the user?

bugfix

Is it a substantial burden for the maintainers to support this?

no

@bdraco bdraco added backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Feb 5, 2025
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 5, 2025
Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #10387 will not alter performance

Comparing stream_total_bytes_fix (b0fa320) with master (8bf5d4d)

Summary

✅ 47 untouched benchmarks

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (8bf5d4d) to head (b0fa320).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10387      +/-   ##
==========================================
- Coverage   98.76%   98.75%   -0.01%     
==========================================
  Files         122      122              
  Lines       37048    37050       +2     
  Branches     2042     2042              
==========================================
- Hits        36590    36589       -1     
- Misses        318      321       +3     
  Partials      140      140              
Flag Coverage Δ
CI-GHA 98.64% <100.00%> (-0.01%) ⬇️
OS-Linux 98.32% <100.00%> (-0.01%) ⬇️
OS-Windows 96.23% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.44% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.33% <100.00%> (-0.01%) ⬇️
Py-3.10.16 97.90% <100.00%> (+<0.01%) ⬆️
Py-3.11.11 97.99% <100.00%> (-0.01%) ⬇️
Py-3.11.9 97.41% <100.00%> (+<0.01%) ⬆️
Py-3.12.8 98.42% <100.00%> (+<0.01%) ⬆️
Py-3.13.1 98.41% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.22% <100.00%> (-0.01%) ⬇️
Py-3.9.21 97.78% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.37% <100.00%> (+<0.01%) ⬆️
VM-macos 97.44% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.32% <100.00%> (-0.01%) ⬇️
VM-windows 96.23% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review February 5, 2025 17:09
@bdraco bdraco merged commit 95b28c7 into master Feb 5, 2025
43 checks passed
@bdraco bdraco deleted the stream_total_bytes_fix branch February 5, 2025 17:10
Copy link
Contributor

patchback bot commented Feb 5, 2025

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/95b28c71fce258f3383ab6ef7f9b6a2a0a65ce46/pr-10387

Backported as #10388

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Feb 5, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/95b28c71fce258f3383ab6ef7f9b6a2a0a65ce46/pr-10387

Backported as #10389

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 5, 2025
bdraco pushed a commit that referenced this pull request Feb 5, 2025
…mReader (#10388)

Co-authored-by: J. Nick Koston <nick@koston.org>
fixes #10386
bdraco pushed a commit that referenced this pull request Feb 5, 2025
…mReader (#10389)

Co-authored-by: J. Nick Koston <nick@koston.org>
fixes #10386
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EmptyStreamReader(StreamReader) inheritance broken
1 participant