Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Skip default headers #486

Merged
merged 11 commits into from
Sep 3, 2015
Merged

Skip default headers #486

merged 11 commits into from
Sep 3, 2015

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Sep 2, 2015

Fix for #457

@asvetlov asvetlov added this to the 0.18 milestone Sep 2, 2015
@asvetlov
Copy link
Member Author

asvetlov commented Sep 3, 2015

@kxepal @fafhrd91 @popravich guys, do you agree with skip_auto_headers parameter name?

@fafhrd91
Copy link
Member

fafhrd91 commented Sep 3, 2015

maybe skip_default_headers ? or is it really auto headers?

@asvetlov
Copy link
Member Author

asvetlov commented Sep 3, 2015

@fafhrd91 it's autogenerated headers.
There is ambiguous for default headers meaning: we have autogenerated headers and ClientSession headers.
Both are used if the header is not specified directly but I don't want skip session's headers by the flag -- user can just don't pass the header into ClientSession constructor.

@fafhrd91
Copy link
Member

fafhrd91 commented Sep 3, 2015

ok, then it is fine.

asvetlov added a commit that referenced this pull request Sep 3, 2015
@asvetlov
Merge pull request #486 from KeepSafe/skip_default_headers
c533d97 
Skip default headers
@asvetlov asvetlov merged commit c533d97 into master Sep 3, 2015
@asvetlov asvetlov deleted the skip_default_headers branch September 3, 2015 23:05
@lock
Copy link

lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
0.18
Development

Successfully merging this pull request may close these issues.
2 participants
@asvetlov @fafhrd91