Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add test for default Expect handler #601

Merged
merged 2 commits into from
Jan 29, 2016

Conversation

redixin
Copy link
Contributor

@redixin redixin commented Oct 28, 2015

Server should return 417 if any of the expectations cannot be met.

http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.20

Server should return 417 if any of the expectations cannot be met.

http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.20
@redixin
Copy link
Contributor Author

redixin commented Oct 28, 2015

Currently expect handler called only if value of Expect header is "100-continue"

It would be much better if default handler could return 417 in case of unknown value of this field.

@asvetlov
Copy link
Member

asvetlov commented Nov 4, 2015

Sorry for delay.

I think the current behavior should be fixed.

Please provide a patch.

@fafhrd91 you've added support for Expect header.
Do you have an objection for shrinking allowed cases?

@fafhrd91
Copy link
Member

fafhrd91 commented Nov 4, 2015

+1

@redixin
Copy link
Contributor Author

redixin commented Nov 18, 2015

I have a doubt. In fact 100-continue is only one known Expect header. This change makes code more strict but slightly harder to use.

@redixin
Copy link
Contributor Author

redixin commented Nov 23, 2015

@asvetlov ping

@asvetlov
Copy link
Member

Let's postpone it until aiohttp 0.19 release

@asvetlov asvetlov added this to the 0.21 milestone Jan 29, 2016
@asvetlov asvetlov merged commit d1e45cc into aio-libs:master Jan 29, 2016
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants