-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature new response property in ClientWebSocketResponse #8572
base: master
Are you sure you want to change the base?
Feature new response property in ClientWebSocketResponse #8572
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8572 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 122 122
Lines 36976 36980 +4
Branches 4412 4413 +1
=======================================
+ Hits 36517 36521 +4
Misses 313 313
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #8572 will not alter performanceComparing Summary
|
What do these changes do?
It is adding a new
response
public attribute to theClientWebSocketResponse
class.It allows users to have access to response headers and cookies of a websocket request without needing to use the private
_response
attribute.Are there changes in behavior for the user?
No
Is it a substantial burden for the maintainers to support this?
No, this is quite straightforward.
Related issue number
Checklist
CONTRIBUTORS.txt
CHANGES/
folder