Fixed OptLocals being passed as the default value for "locals" #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be useful for debugging when the event loop thread is stuck.
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
======================================
Coverage 92.8% 92.8%
======================================
Files 4 4
Lines 250 250
Branches 32 32
======================================
Hits 232 232
Misses 11 11
Partials 7 7
Continue to review full report at Codecov.
|
jettify
reviewed
Jul 5, 2018
| @@ -31,7 +31,7 @@ def start_monitor(loop: Loop, *, | |||
| port: int=MONITOR_PORT, | |||
| console_port: int=CONSOLE_PORT, | |||
| console_enabled: bool=True, | |||
| locals=OptLocals) -> 'Monitor': | |||
| locals: OptLocals = None) -> 'Monitor': | |||
There was a problem hiding this comment.
Odd, probably mypy is not configured properly
|
I tweaked mypy settings as result now we can spot such errors during CI #123 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.