Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve performance of with_fragment #1317

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Improve performance of with_fragment #1317

merged 2 commits into from
Oct 17, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 17, 2024

Avoid calling SplitResult._replace since its much slower

Copy link

codspeed-hq bot commented Oct 17, 2024

CodSpeed Performance Report

Merging #1317 will improve performances by 84.01%

Comparing with_fragment (1b81de2) with master (96649e7)

Summary

⚡ 1 improvements
✅ 75 untouched benchmarks

Benchmarks breakdown

Benchmark master with_fragment Change
test_url_with_fragment 807.1 µs 438.6 µs +84.01%

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.94%. Comparing base (96649e7) to head (1b81de2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1317   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files          27       27           
  Lines        5373     5375    +2     
  Branches      326      326           
=======================================
+ Hits         5155     5157    +2     
  Misses        192      192           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 95.94% <100.00%> (+<0.01%) ⬆️
MyPy 44.51% <100.00%> (+0.02%) ⬆️
OS-Linux 99.31% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.37% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.04% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 99.01% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 99.01% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 99.27% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 98.97% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.22% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.27% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.29% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.04% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.31% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.37% <100.00%> (+<0.01%) ⬆️
pytest 99.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Oct 17, 2024

We don't have any benchmarks that actually alter the fragment

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 17, 2024
@bdraco bdraco marked this pull request as ready for review October 17, 2024 23:51
@bdraco bdraco merged commit ee0e509 into master Oct 17, 2024
43 of 46 checks passed
@bdraco bdraco deleted the with_fragment branch October 17, 2024 23:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant