-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Break out functions that do not need decorated methods #1345
Conversation
classmethods are slower than normal methods, and these methods never need anything on the URL objects like _normalize_path_segments
CodSpeed Performance ReportMerging #1345 will improve performances by 20.84%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1345 +/- ##
==========================================
+ Coverage 96.02% 96.09% +0.07%
==========================================
Files 27 27
Lines 5479 5482 +3
Branches 338 336 -2
==========================================
+ Hits 5261 5268 +7
+ Misses 192 188 -4
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm not sure the static method is actually slower If not might be nicer to make them static instead as it's less change |
For this case, this change makes the most sense since we have some of them calling each other |
staticmethod is a tiny bit slower |
classmethod
s andstaticmethod
s are slower than normal methods, and these methods never need anything on the URL objects like_normalize_path_segments