-
-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: bump Go to 1.22 #529
Conversation
Hey @cosmtrek - a new release supporting the latest version of go would be reaallyyy nice. Air is preventing my team from bumping our projects to 1.22 (since it breaks our engineers' local dev worklows). |
@troutowicz Hi, could you fix the tests? Thanks |
Hey @cosmtrek, removed that second commit. Will address GH action config another time. |
go.mod
Outdated
@@ -1,6 +1,6 @@ | |||
module github.com/cosmtrek/air | |||
|
|||
go 1.21 | |||
go 1.22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to keep this on the major version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially tried this but received the following error on go mod tidy
go: downloading go1.22 (darwin/arm64)
go: download go1.22 for darwin/arm64: toolchain not available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Was a local installation issue.
We were having the same issue. However, for future blocks, I think setting a newer toolchain will address local dev workflows.
|
Hey @cosmtrek -- sorry to bother again. Can we merge this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 69.22% 65.28% -3.94%
==========================================
Files 9 10 +1
Lines 1082 1158 +76
==========================================
+ Hits 749 756 +7
- Misses 253 324 +71
+ Partials 80 78 -2 ☔ View full report in Codecov by Sentry. |
No description provided.