Add exiter to test os.Exit case #729

xiantang · 2025-01-19T14:06:18Z

No description provided.

xiantang · 2025-01-19T14:08:50Z

codecov · 2025-01-19T14:09:07Z

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
runner/engine.go	37.50%	4 Missing and 1 partial ⚠️
runner/exiter.go	0.00%	2 Missing ⚠️

Files with missing lines	Coverage Δ
runner/exiter.go	`0.00% <0.00%> (ø)`
runner/engine.go	`59.96% <37.50%> (+<0.01%)`	⬆️

runner/engine_test.go

runner/exiter.go

runner/engine_test.go

runner/engine.go

ccoVeille · 2025-01-19T14:49:19Z

runner/engine_test.go

+				if ret != 0 {
+					e.exiter.Exit(ret)
+				}
+			case <-time.After(1 * time.Millisecond):


10 ms could avoid flakiness on some strange use case

ccoVeille · 2025-01-19T14:50:24Z

runner/engine_test.go

+			setup: func(_ *Engine, _ chan<- int) {
+			},


Maybe adding a time.Sleep here would make it clearer to anyone reading this

ccoVeille · 2025-01-19T14:54:41Z

runner/engine_test.go

+	}
+}
+
+func TestEngineExit(t *testing.T) {


I'm unsure I get it

You are no longer calling stopBin, so here you are testing the test exiter behavior?

I mean I don't get you are calling the exiter itself in this method

🤔

Did I miss something?

You had the call to stopBin earlier, no?

ccoVeille · 2025-01-19T14:57:34Z

Why merging so fast? It was a test

xiantang · 2025-01-20T01:29:40Z

it’s too late at my timezone. Will check your comment

…

On Sun, 19 Jan 2025 at 10:57 PM, ccoVeille ***@***.***> wrote: Why merging so fast? It was a test — Reply to this email directly, view it on GitHub <#729 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIHB3T7Z5A42JPM2UOMDJW32LO4PHAVCNFSM6AAAAABVOXQCNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBQHA4TIOBYHA> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

ccoVeille · 2025-01-22T13:42:54Z

it’s too late at my timezone. Will check your comment

Thanks. Could you then?

* chore: bump go to 1.23 (air-verse#650) * docs: update banner (air-verse#651) * fix proxy retry loop (air-verse#635) This addresses two bugs: 1) The loop could exit with an error condition present and fail to inform the user. 2) On Windows 11, syscall.ECONNREFUSED is not returned. Instead we receive net.OpError with a message similar to: "unable to reach app: Get "http://localhost:7000/": dial tcp [::1]:7000: connectex: No connection could be made because the target machine actively refused it." The Fix: Since the retry loop is short; just 1 second maximum, we retry until no error happens. If an error does occur, we inform the user. * Use web page address when making request to reload proxy (air-verse#625) * Use web page address when making request to reload proxy Signed-off-by: Alexandra Fishova <yopoyka@yopoyka.com> * Create event source with just a path because browser can handle address on its own. Signed-off-by: Alexandra Fishova <yopoyka@yopoyka.com> --------- Signed-off-by: Alexandra Fishova <yopoyka@yopoyka.com> * fix the stop_on_error is false configuration does not work (air-verse#555) * fix color output (air-verse#551) * Set the Via header in proxy requests to origin and in client responses (air-verse#629) * Set the Via header in proxy requests to origin and in client responses * Remove pseudonym and use host only * feat: Make include_file overrule include_ext, fixes: air-verse#350, base_on: air-verse#358 (air-verse#416) * feat: Make include_file overrule include_ext * feat: Make include_file overrule include_ext unittest * fix: broken code (air-verse#652) * feat: silent flag in .air.toml, suppressing all air prints (air-verse#641) * feat: silent flag in .air.toml, suppressing all air prints useful if the app being watched has structured outputs that are being piped into subsequent program/s. * update: add silent to air_example.toml * FIX: Support working directories containing whitespace (air-verse#646) * encapsulate paths with quotes to escape spaces * encapsulate paths with quotes to escape spaces * preprocess error in test * Revert "FIX: Support working directories containing whitespace (air-verse#646)" (air-verse#665) This reverts commit df13da5. * refactor: remove unnecessary var copy in for (air-verse#682) * docs: fix badge link in README-zh_cn.md (air-verse#681) * refactor: simplify test asserts; enable testifylint (air-verse#680) * Update unclear .profile changes in README.md (air-verse#684) * Fix: typo in air_example.toml (air-verse#706) * Implement kill delay on Windows (air-verse#552) * fix color output * Implement kill delay on Windows * Revert the change on master * Remove extra newline * Handle absolute paths in config (air-verse#318) * remove a data race by compiling the exclude regexes in the preprocess phase (air-verse#677) the regex compilation was done lazily on first access but did not properly synchronize for being accessed by multiple watcher goroutines between the option of adding a mutex for something that (should) only ever happen once and removing the potential for a race, this seems like the better choice * catch and report start cmd failure rather than panicing (air-verse#676) * do not report the process as running if it failed to start * change the return values on error to match what the other platforms produce * chore: fix test case TestRegexes * air -h will be document of air * Update README for air help command * fix: default config override (air-verse#719) * Avoid duplicating cors header. (air-verse#727) * fix: typos (air-verse#728) * wait for killfunc completion when shutting down current app (air-verse#670) * wait for killfunc completion when shutting down current app --------- Co-authored-by: jingdi.zhu <jingdi.zhu@bytedance.com> * Feature: Show build errors when using proxy (air-verse#725) * proxy: stream reload and error messages * proxy: Console log on build failure * proxy: show build errors in a modal --------- Co-authored-by: xiantang <zhujingdi1998@gmail.com> * Add exiter to test os.Exit case (air-verse#729) authored-by: jingdi.zhu <jingdi.zhu@bytedance.com> * Fix: using powershell instead of cmd /C (air-verse#708) --------- Signed-off-by: Alexandra Fishova <yopoyka@yopoyka.com> Co-authored-by: Rick Yu <m@c6k.app> Co-authored-by: Greg Dietsche <greg@gregd.org> Co-authored-by: Alexandra Fishova <yopoyka@yopoyka.com> Co-authored-by: dengdajun <78243198+pyjcode@users.noreply.github.com> Co-authored-by: 8LWXpg <105704427+8LWXpg@users.noreply.github.com> Co-authored-by: dedalusj <dedalusj@gmail.com> Co-authored-by: zhb127 <1224680008@qq.com> Co-authored-by: ~ jesse ~ <113159758+jesses-code-adventures@users.noreply.github.com> Co-authored-by: osteensco <86266589+osteensco@users.noreply.github.com> Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com> Co-authored-by: Gourav Kolhatkar <gstar1525@gmail.com> Co-authored-by: Olivia Bahr <ob.bahr@gmail.com> Co-authored-by: ZipFile <lin.aaa.lin@gmail.com> Co-authored-by: Isak Styf <isak@styfsoftware.se> Co-authored-by: xiantang <zhujingdi1998@gmail.com> Co-authored-by: Nemanja Milićević <the.nemanja.milicevic@gmail.com> Co-authored-by: Brandon Bloom <brandon.d.bloom@gmail.com> Co-authored-by: Nathan Baulch <nathan.baulch@gmail.com> Co-authored-by: jingdi.zhu <jingdi.zhu@bytedance.com> Co-authored-by: Polo123456789 <57022222+Polo123456789@users.noreply.github.com> Co-authored-by: Po <73031052+n1vk@users.noreply.github.com>

ccoVeille · 2025-02-15T10:01:32Z

Why merging so fast? It was a test

it’s too late at my timezone. Will check your comment

@xiantang unless I'm wrong, you didn't. I would appreciate a reply, especially for the first one

xiantang mentioned this pull request Jan 19, 2025

wait for killfunc completion when shutting down current app #670

Merged

ccoVeille reviewed Jan 19, 2025

View reviewed changes

runner/engine_test.go Outdated Show resolved Hide resolved

runner/exiter.go Outdated Show resolved Hide resolved

runner/engine_test.go Outdated Show resolved Hide resolved

ccoVeille reviewed Jan 19, 2025

View reviewed changes

runner/engine.go Outdated Show resolved Hide resolved

xiantang force-pushed the exit_runner branch 2 times, most recently from f7febd4 to 2c74951 Compare January 19, 2025 14:46

Add exiter to test os.Exit case

ce50989

xiantang force-pushed the exit_runner branch from 2c74951 to ce50989 Compare January 19, 2025 14:55

xiantang merged commit ad8fbb7 into master Jan 19, 2025
14 checks passed

ccoVeille reviewed Jan 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add exiter to test os.Exit case #729

Add exiter to test os.Exit case #729

xiantang commented Jan 19, 2025

xiantang commented Jan 19, 2025

codecov bot commented Jan 19, 2025 •

edited

Loading

ccoVeille Jan 19, 2025

ccoVeille Jan 19, 2025

ccoVeille Jan 19, 2025 •

edited

Loading

ccoVeille commented Jan 19, 2025

xiantang commented Jan 20, 2025 via email

ccoVeille commented Jan 22, 2025

ccoVeille commented Feb 15, 2025

Add exiter to test os.Exit case #729

Add exiter to test os.Exit case #729

Conversation

xiantang commented Jan 19, 2025

xiantang commented Jan 19, 2025

codecov bot commented Jan 19, 2025 • edited Loading

Codecov Report

ccoVeille Jan 19, 2025

Choose a reason for hiding this comment

ccoVeille Jan 19, 2025

Choose a reason for hiding this comment

ccoVeille Jan 19, 2025 • edited Loading

Choose a reason for hiding this comment

ccoVeille commented Jan 19, 2025

xiantang commented Jan 20, 2025 via email

ccoVeille commented Jan 22, 2025

ccoVeille commented Feb 15, 2025

codecov bot commented Jan 19, 2025 •

edited

Loading

ccoVeille Jan 19, 2025 •

edited

Loading