Skip to content

fixed execSync issue in windows #2700 #2706

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed execSync issue in windows #2700 #2706

wants to merge 1 commit into from
+2 −4

Conversation

kapilsriram
Copy link

@kapilsriram kapilsriram commented Jan 6, 2023 •
edited
Loading

#2700 as discussed here, execSync() is opening the file instead of executing the file in windows. Hence appenindg "node " before the file name, to make it work as exepcted.

@ljharb ljharb mentioned this pull request Mar 4, 2025
Draft
@zaycker
Copy link

zaycker commented Mar 4, 2025 •
edited
Loading

@kapilsriram could you fix conflicts please as @ljharb advised me to ask.
also, could you add please windowsHide: true to the options of execAsync. we have NX monorepo with 30+ subprojects and sometimes it generates cmd windows without this property during dev build with the eslint as a part of the process

@zaycker
Copy link

zaycker commented Mar 16, 2025

@kapilsriram could you fix conflicts please
cc @ljharb

@Xtrum

This comment was marked as spam.

# to view
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@stefan-stanca stefan-stanca stefan-stanca approved these changes

@anandfresh anandfresh anandfresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kapilsriram @zaycker @Xtrum @stefan-stanca @anandfresh