Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix ImageAssetManager.bitmapForId NPE crash #2117

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Fix ImageAssetManager.bitmapForId NPE crash #2117

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
693c9d9
Fix ImageAssetManager.bitmapForId NPE crash
Aug 8, 2022
5aca68a
Fix ImageAssetManager.bitmapForId NPE crash, add id in Logger output
Aug 9, 2022
9e14510
Add id in Logger output for ImageAssetManager.bitmapForId if decodeSt…
Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lottie/src/main/java/com/airbnb/lottie/manager/ImageAssetManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,11 @@ public void setDelegate(@Nullable ImageAssetDelegate assetDelegate) {
try {
bitmap = BitmapFactory.decodeStream(is, null, opts);
} catch (IllegalArgumentException e) {
Logger.warning("Unable to decode image.", e);
Logger.warning("Unable to decode image `" + id + "`.", e);
return null;
}
if (bitmap == null) {
Logger.warning("Decoded image `" + id + "` is null.");
hsrzq marked this conversation as resolved.
Show resolved Hide resolved
return null;
}
bitmap = Utils.resizeBitmapIfNeeded(bitmap, asset.getWidth(), asset.getHeight());
Expand Down