Add the LottieConfig.Builder.setEnableNetworkCache() method to completely disable internal network cache if needed #2158
Conversation
…tely disable internal network cache if needed
| @@ -47,6 +49,10 @@ public static void setTraceEnabled(boolean enabled) { | |||
| } | |||
| } | |||
|
|
|||
| public static void setNetworkCacheEnabled(boolean enabled) { | |||
There was a problem hiding this comment.
Can you add a javadoc for this? Also indicate that it will evict existing cache entries.
There was a problem hiding this comment.
But L class is restricted to the library scope, and there are no other javadocs there. I've added javadocs to the publicly accessible LottieConfig.Builder.setEnableNetworkCache(), should I just copy-paste them here as well?
Also disabling the cache should not evict existing cache entries I believe, they will still be there until the explicit LottieCompositionFactory.clearCache() call with the cache enabled.
|
@gpeal also added a small docs PR here - airbnb/lottie#211 |
Add docs to support disabling Lottie's internal network cache, see airbnb/lottie-android#2158
|
btw @gpeal are there any plans to release a new Lottie version with all those recent changes? |
|
Yes, soon! You can use the SNAPSHOT release if you'd like, too. |
Rationale
We'd like to implement more sophisticated caching strategy for animations fetched from network. This could be implemented on the network fetcher level e.g. using the OkHttp's cache or the "stale-while-revalidate" strategy.
For this to work the internal Lottie network cache has to be completely disabled.
The option to do so is implemented in this PR.
Implementation
By default the internal cache is enabled to maintain backward compatibility.
We've added the
LottieConfig.Builder.setEnableNetworkCache()method to override the default behavior.