Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Docs: streams table #24326

Merged
merged 13 commits into from
Mar 28, 2023
Merged

Docs: streams table #24326

merged 13 commits into from
Mar 28, 2023

Conversation

sophia-wiley
Copy link
Contributor

@sophia-wiley sophia-wiley commented Mar 21, 2023

Updated docs for the new stream table.

The UI for the new streams table has been updated, so I updated docs to reflect those changes and made new gifs to show the updated UI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 21, 2023
@sophia-wiley
Copy link
Contributor Author

gif-single-edit-march-2023

@sophia-wiley
Copy link
Contributor Author

gif-batch-edit-march-2023

@edmundito edmundito requested a review from andyjih March 22, 2023 18:50
Copy link
Contributor

@andyjih andyjih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have a few comments/edits.

sophia-wiley and others added 2 commits March 23, 2023 18:54
Co-authored-by: Andy Jih <andyjih@users.noreply.github.com>
Co-authored-by: Andy Jih <andyjih@users.noreply.github.com>
@sophia-wiley
Copy link
Contributor Author

@andyjih thanks for taking a look! I committed your suggestions.

@sophia-wiley sophia-wiley requested a review from andyjih March 27, 2023 15:08
Copy link
Contributor

@edmundito edmundito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had some minor comments about this. I had a bigger note about how to refer to the primary keys; the user can always select multiple.

@@ -1,94 +1,158 @@
# Edit stream configuration
# Manage syncs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if manage syncs is a good name for this. We're not managing the syncs here. What was there before makes more sense to me.


To save the changes:
1. Click **Save changes**, or click **Cancel** to discard the changes.
7. Click the **X** to close the stream details panel.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
7. Click the **X** to close the stream details panel.
7. Click the **X** on the top right to close the stream details panel.

sophia-wiley and others added 2 commits March 28, 2023 16:05
Co-authored-by: Edmundo Ruiz Ghanem <168664+edmundito@users.noreply.github.com>
edited based on Edmundo's suggestions
@sophia-wiley sophia-wiley merged commit 3ba5a3c into master Mar 28, 2023
@sophia-wiley sophia-wiley deleted the docs_streams_table branch March 28, 2023 16:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants