Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

TVOC in display should be in all caps #139

Closed
MallocArray opened this issue May 18, 2024 · 8 comments
Closed

TVOC in display should be in all caps #139

MallocArray opened this issue May 18, 2024 · 8 comments

Comments

@MallocArray
Copy link
Contributor

Like other sensor names, TVOC should be in all caps, not lower case.

It is an acronym and should be capitalized, as well as matching the formatting of all of the other displayed readings.

Also, I believe it should be VOC instead of TVOC, as that is what the manufacturer refers to it at:
https://sensirion.com/products/catalog/SGP40/

@airgradienthq
Copy link
Owner

@pnt325 @MallocArray is correct. Please change the display unit from "tvoc" to "VOC".

pnt325 added a commit that referenced this issue Jul 8, 2024
@pnt325
Copy link
Contributor

pnt325 commented Jul 8, 2024

@airgradienthq
IMG_1324

@MallocArray
Copy link
Contributor Author

I like the capitals.

Still think the spacing of the columns could be improved. No reason for all of the blank space to the right of VOC and PM2.5 could still use some extra room.

This is what my ESPHome firmware looks like (Top line wasn't included due to my camera shutter being too fast)

image

@airgradienthq
Copy link
Owner

@pnt325 Please also adjust the layout as @MallocArray suggests. Then make a new pull request.

pnt325 added a commit that referenced this issue Jul 18, 2024
@pnt325
Copy link
Contributor

pnt325 commented Jul 18, 2024

d0bde8b4f6fc53a20aed

I update the layout for 4 character value of CO2 and 3 character value of PM.

@MallocArray
Copy link
Contributor Author

I like it!

@airgradienthq
Copy link
Owner

@pnt325 Perfect. Let's go with that.

@pnt325
Copy link
Contributor

pnt325 commented Jul 19, 2024

@airgradienthq Please check and aprrove PR #195

@pnt325 pnt325 closed this as completed Jul 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants