Fix pm2.5 compensation formula #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pnt325
commented
Aug 26, 2024
pnt325
commented
- Fix: formular missing pow of 2
- Optimize for float number calculations
- Fix Check Compensation Formula #225
nick-4711
changed the title
nick-4711
reviewed
Aug 27, 2024
src/PMS/PMS.cpp
Outdated
| @@ -295,29 +295,32 @@ int PMSBase::pm25ToAQI(int pm02) { | |||
| /** | |||
| * @brief Correction PM2.5 | |||
| * | |||
| * Formula: https://github.com/airgradienthq/arduino/issues/182 | |||
There was a problem hiding this comment.
I like the link but in there we also don't have sufficient information what this formula is.
There was a problem hiding this comment.
So, I don't know details of the formular, Just got it from @airgradienthq to implement.
There was a problem hiding this comment.
We can link to
https://www.airgradient.com/documentation/correction-algorithms/
Ideally we can also write a few test cases and verify that we get the expected value in each value range.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.