ENG-1551 ai xplain sdk caching onboarded models pipelines and agents #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetgunduz
requested changes
Feb 6, 2025
There was a problem hiding this comment.
@xainaz Thanks for the PR!
I have a main issue with the current iplementation. We have separate cache methods for models, pipelines and agents. This will make very hard for us to make any change in future. Having all into one class named AixplainCache object that has more modular desigh such that the utils methods and all repetitive methods for different asset types should be part of this class.
Can you please redesign your codebase if this make sense to you. Otherwise we can discuss to find a way to make it more modular .
ahmetgunduz
requested changes
Feb 10, 2025
There was a problem hiding this comment.
@xainaz Can you please add functional test for it? i approved the rest.
thiago-aixplain
suggested changes
Mar 18, 2025
thiago-aixplain
changed the title
kadirpekel
reviewed
Mar 20, 2025
kadirpekel
reviewed
Mar 20, 2025
kadirpekel
reviewed
Mar 20, 2025
kadirpekel
reviewed
Mar 20, 2025
kadirpekel
reviewed
Mar 20, 2025
kadirpekel
reviewed
Mar 20, 2025
kadirpekel
reviewed
Mar 20, 2025
kadirpekel
reviewed
Mar 20, 2025
kadirpekel
reviewed
Mar 20, 2025
kadirpekel
reviewed
Mar 20, 2025
kadirpekel
reviewed
Mar 20, 2025
kadirpekel
reviewed
Mar 20, 2025
kadirpekel
reviewed
Mar 20, 2025
kadirpekel
reviewed
Apr 10, 2025
kadirpekel
reviewed
Apr 10, 2025
kadirpekel
reviewed
Apr 23, 2025
kadirpekel
reviewed
Apr 23, 2025
kadirpekel
reviewed
Apr 23, 2025
kadirpekel
reviewed
Apr 23, 2025
kadirpekel
reviewed
Apr 23, 2025
kadirpekel
reviewed
Apr 23, 2025
kadirpekel
reviewed
Apr 23, 2025
kadirpekel
approved these changes
May 5, 2025
…ded-models-pipelines-and-agents
…ded-models-pipelines-and-agents
…lain-sdk-caching-onboarded-models-pipelines-and-agents
thiago-aixplain
approved these changes
May 12, 2025
ahmetgunduz
approved these changes
May 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added file lock, global expiry time in seconds is configurable as an environmental variable.