-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ENG-1392: SQL tool in Agents #400
Conversation
thiago-aixplain
commented
Feb 12, 2025
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my review comments in agentification repo and then we can update here: https://github.com/aixplain/agentification/pull/222/files
description: Text, | ||
database: Text, | ||
schema: Text, | ||
table: Optional[Text] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tables?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also can we support csv uploading. Please check my comment in agentification pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enable_commit
is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comment
aixplain/v2/agent.py
Outdated
return AgentFactory.create_custom_python_code_tool(code=code, description=description) | ||
|
||
@classmethod | ||
def create_sql_tool(cls, description: str, database: str, schema: str, table: Optional[str] = None) -> "SQLTool": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have tables as well:
tables: Optional[List[Text]]