Eng 1392 sqllite #421
Merged
Eng 1392 sqllite #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiago-aixplain
requested changes
Mar 6, 2025
thiago-aixplain
requested changes
Mar 6, 2025
thiago-aixplain
approved these changes
Mar 7, 2025
| @@ -193,7 +196,8 @@ def create_custom_python_code_tool(cls, code: Union[Text, Callable], description | |||
| def create_sql_tool( | |||
| cls, | |||
| description: Text, | |||
| database: Text, | |||
| source: str, | |||
| source_type: str, | |||
There was a problem hiding this comment.
Should we consider a default option?
Moreover can we do a Union on the typing hint with the Enumerators as well?
There was a problem hiding this comment.
I do not think we need a default option here. Because there could be many different ways to create sql tool
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.