Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Render bidirectional unicode characters as control characters #4693

Merged
merged 1 commit into from
May 11, 2022

Conversation

andrewnester
Copy link
Contributor

Description of changes:

Render bidirectional unicode characters as control characters.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #4693 (52cc808) into master (7cc98c7) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4693      +/-   ##
==========================================
+ Coverage   71.19%   71.23%   +0.04%     
==========================================
  Files         553      553              
  Lines       55585    55585              
  Branches    10391    10391              
==========================================
+ Hits        39571    39598      +27     
+ Misses      16014    15987      -27     
Flag Coverage Δ
unittests 71.23% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ace/layer/text.js 91.11% <100.00%> (ø)
lib/ace/editor.js 81.61% <0.00%> (+1.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc98c7...52cc808. Read the comment docs.

@andrewnester andrewnester merged commit 4d2ecf0 into ajaxorg:master May 11, 2022
@andrewnester andrewnester deleted the bidirectional-chars branch May 11, 2022 07:06
jeroenpost86 pushed a commit to jeroenpost86/ace that referenced this pull request May 19, 2022
* 'master' of https://github.com/ajaxorg/ace:
  fix: Made commas be tokenized as punctuation operator instead of text in JSON (ajaxorg#4703)
  fix: Multiple Partiql and Amazon Ion textual notation fixes (ajaxorg#4686)
  fix: Updated PHP mode to support PHP8.1 syntax (ajaxorg#4696)
  release v1.5.0
  chore: use npm changelog in release script (ajaxorg#4698)
  feat: Added ability to configure certain format options for beautify extension
  fix: Render bidirectional unicode characters as control characters (ajaxorg#4693)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants