-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
move code to src folder and switch to commonjs #4851
Conversation
48972c4
to
a0b78c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #4851 +/- ##
===========================================
+ Coverage 70.07% 85.74% +15.67%
===========================================
Files 557 539 -18
Lines 58221 40602 -17619
Branches 11195 6419 -4776
===========================================
- Hits 40796 34814 -5982
+ Misses 17425 5788 -11637
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
The directory structure was changed in ajaxorg/ace#4851
@nightwing @andrewnester 👋 from github/linguist, the library responsible for language detection on github.com, and other places. This PR has come to my attention as one of our tests has started failing because of this change. GitHub no longer uses the Ace editor (it hasn't for quite some time) however we maintain a check against Ace modes for all languages added for third-party users of the gem that may still be using Ace. A change on our side is easy enough to implement (change the path), but I'm curious to know what the rationale is for this change as it's not explained in the OP and there's no referencing issue. Also, were https://github.com/ajaxorg/ace/blob/master/lib/ace/mode/jsoniq.js and https://github.com/ajaxorg/ace/blob/master/lib/ace/mode/xquery.js deliberately left in Having these two files in the old location makes our change a little more complicated as we now need to query two locations. I'm also trying to judge if things are likely to change again within the near future. |
HI @lildude ! Thanks for reaching out! The mentioned modes are deliberately left in the lib folders :) |
* Update ace mode path The directory structure was changed in ajaxorg/ace#4851 * Grab both locations
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.