Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: highlight indent guides with wrapped lines #5621

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Aug 6, 2024

Issue #, if available: #5619

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.97%. Comparing base (26eda25) to head (6a4cdac).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
src/layer/text.js 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5621      +/-   ##
==========================================
+ Coverage   86.89%   86.97%   +0.07%     
==========================================
  Files         594      594              
  Lines       43151    43395     +244     
  Branches     7151     7170      +19     
==========================================
+ Hits        37497    37742     +245     
+ Misses       5654     5653       -1     
Flag Coverage Δ
unittests 86.97% <83.33%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andredcoliveira andredcoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should line 12's second indent guide also be highlighted?

Screenshot 2024-09-10 at 13-37-09 Ace Kitchen Sink

Checked using https://raw.githack.com/ajaxorg/ace/80a8379818bb0e058f223a279aa86f716938fca5/kitchen-sink.html

@mkslanc
Copy link
Contributor Author

mkslanc commented Sep 24, 2024

Should line 12's second indent guide also be highlighted?

Screenshot 2024-09-10 at 13-37-09 Ace Kitchen Sink

Checked using https://raw.githack.com/ajaxorg/ace/80a8379818bb0e058f223a279aa86f716938fca5/kitchen-sink.html

New changes should make it

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants