fix: ignoring dangling images from image list #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update install instructions
Update install from source instructions to `HEAD` (instead of commit ID)
Signed-off-by: ashishkhuraishy <ashishkhuraishy@gmai.com>
|
Hey, thanks for the PR. Also I'd like a test case if you can add one. Could you also add a check in Push your changes to thanks! |
|
@ajayd-san the changes for fix + some linting errors has been fixed |
|
Perfect. Thanks for your contribution! |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIX] App panics on startup
When one or more dangling images where found, the app crashed on startup because here trying to access out of bounds object from an empty array
Solved it by only considering non-dangling images as part of image list, such that there would be atleast one valid tag on the image
fixes #18