Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve performance enumerating page links. #75

Closed
ajrcarey opened this issue Mar 10, 2023 · 2 comments
Closed

Improve performance enumerating page links. #75

ajrcarey opened this issue Mar 10, 2023 · 2 comments
Assignees
@ajrcarey

Comments

@ajrcarey
Copy link
Owner

Follow-on from #68. Pdfium does not provide a way to determine how many links are included in a page. For the PdfPageLinks::len() function, #68 implemented a very naive linear traversal to discover the number of links. Rework this, and associated functions, to use a binary search technique instead for improved performance.
@ajrcarey ajrcarey self-assigned this Mar 10, 2023
@ajrcarey
Copy link
Owner Author

Reworked PdfPageLinks::len() to use a sliding interval search technique rather than linear traversal. Simplified PdfPageLinksIterator implementation. Completed in time for release 0.7.34.

@ajrcarey
Copy link
Owner Author

Fixed minor typos in documentation. Added a new NoPageLinksInCollection enum variant to PdfiumError rather than reusing NoPageObjectsInCollection variant. Improved performance of PdfPageLinks::first() and PdfPageLinks::last() functions.

ajrcarey pushed a commit that referenced this issue Mar 11, 2023
Resolves #75
1014d33
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ajrcarey ajrcarey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajrcarey